Yoann Padioleau comments

Results 358 comments of


                                            Yoann Padioleau

[JSX] change default set of JSX equivalences.

You're right! Ok, I'll modify the engine but we will have to modify a few semgrep-rules then.

[JSX] change default set of JSX equivalences.

What about the attributes? should we require ... in the list of attributes to say more are ok? Or have it implicit like we do inside objects or classes?

[JSX] change default set of JSX equivalences.

Inside object or classes right now you don't have to put '...', which may not be right. I think it's better to require '...' for attributes (and probably also for...

[JSX] change default set of JSX equivalences.

:wave:

Java naming bug

This is because in the first while, the cond is unresolved, and we currently allow an unresolved variable to match a resolved variable (see the comment in Matching_generic.equal_ast_binded_code why) if...

Add a cli argument to completely disable . semgrepignore

I agree, I think it would be useful, especially because when there's no .semgrepignore we apply a default one

style: Add styling to details and shortlink textual output

LGTM. Not sure why osemgrep test is failing. The output actually looks similar.

style: Add styling to details and shortlink textual output

Did you manage to fix this one?

prebuild opam.exe binary refuse to run init under Powershell or Cmd (When AppData/Local/opam already exist)

This is from a windows machine with vistual studio build tools 2022 installed, but no cygwin at all

prebuild opam.exe binary refuse to run init under Powershell or Cmd (When AppData/Local/opam already exist)

hmm I think it's because of my left AppData/Local/opam from a previous failed install