Arya Emami comments

Results 185 comments of


                                            Arya Emami

`UpdateDefinitions` type not exported from `@reduxjs/toolkit/dist/query/endpointDefinitions`

@mchill Thanks for the repro, I fixed the issue, can you try this and let me know if it fixes the problem? ```bash npm install https://pkg.csb.dev/reduxjs/redux-toolkit/commit/51afa9fc/@reduxjs/toolkit ```

vite-template-redux: Skip linting vite.config.ts, as it's not covered by tsconfig.json

I already have a fix for this but I appreciate the effort.

false equality with exactOptionalPropertyTypes

I'm a little late to the party, I'm going to see if there is a simple solution to this.

Format all files

@timdorr sure.

Repo: address issues introduced by updated `nx` configuration

> 1. This was me being dumb thinking that missing the config off would not create the target, rather than fallback to the default name. > > I am discussing...

Repo: address issues introduced by updated `nx` configuration

@kirkwaiblinger > My only question with the project-level configs is - won't the root eslint config still apply to the projects/workspaces when executing eslint? Or does nx infer a lint...

Repo: address issues introduced by updated `nx` configuration

@kirkwaiblinger > My concern is that executing that verbatim will lint the `packages/**/*` as well unless we exclude them, which duplicates work with the package-level tasks. We used to have...

Improve treeshakeability of build artifacts

Yeah let's do the size limit one first. Do you want me to get rid of the browser artifact?

Improve treeshakeability of build artifacts

The CI example app for cra4 failed when I added it. Edit: The cra4 example app failed for React-Redux when I added it, it failed because it has a `.mjs`...

Improve treeshakeability of build artifacts

## Other changes to consider adding: 1. We could add a top level `unpkg` field to `package.json` and set it to `"./dist/reselect.browser.mjs"` as currently the default build artifact consumed by...