Arya
Arya
> I'm not sure we want `zebra-rpc` to serve as a library for random functionality. Since the function is small, isn't it better to just copy it to Zaino, or...
@gustavovalverde any idea why CI on this PR seems stuck?
> Let me know if you'd like for me to merge this. Yes please, it can't hurt to have it factored out, even if it ends up not being used...
> Currently Zebra checks the mempool every 5 seconds. But we could check every 1 second (or every hundred milliseconds) if miners want that. Since the mempool is all in...
Selecting the `shielded-scan` feature caused both failures: https://github.com/ZcashFoundation/zebra/actions/runs/10596330182/job/29364063788#step:10:368, https://github.com/ZcashFoundation/zebra/actions/runs/11299770857/job/31431392221#step:10:378 It's being [passed in here](https://github.com/ZcashFoundation/zebra/blob/main/.github/workflows/release-binaries.yml#L30).
> Following the work on `CommitSemanticallyVerifiedBlock` and the suggestion to outline remaining paths, here’s a checklist of `Request` variants in `StateService` and `ReadStateService` that return boxed errors (`BoxError`). > ......
@syszery I opened https://github.com/ZcashFoundation/zebra/pull/9923 with some minor cleanups, the main notes are to: - prefer new error enums over adding variants to existing error types, - convert request error types...
It would be nice to also split the `ReadStateService` into multiple `Service` impls with their own concrete request, response, and error types. It's difficult to do that for the state...
Alternatively, we may want to add a CI job that runs on PRs with the `A-release` label to do this check.
[The last one](https://github.com/ZcashFoundation/zebra/actions/runs/18779417191/job/53651476220#step:12:292) is concerning, it looks like another instance of #10044. The other two seem to be a less concerning issue with `future_blocks()`, `raw_future_blocks()`, or restarting Zebra without peers.