Arya

icon indicating a website link arya.rocks

icon location Toronto icon location a person who likes version control

Results 92 comments of Arya

add(chain): Impl `zcash_protocol::consensus::Parameters` for `Network`

@Mergifyio refresh

fix(state): Always return updated trees in `NoteCommitmentTree` update methods

There was a known test failure on Windows: https://github.com/ZcashFoundation/zebra/actions/runs/8820859044/job/24215403949?pr=8459#step:12:4697

fix(state): Always return updated trees in `NoteCommitmentTree` update methods

> Do we need to disable some tests on Windows? @mpguerra That seems like a good idea for now, I opened #8468 for disabling the test that's failing and #8461...

fix(state): Always return updated trees in `NoteCommitmentTree` update methods

This PR doesn't really change anything.

main branch CI failed: schedule in Integration Tests on GCP

> We should prioritise this as it seems to be happening a lot lately We know why 4 of the 5 most recent failures happened and have fixed the issues...

Add semantic block validation during the ZIP-212 grace period after Canopy activation

Both the latest version of `zcash_primitives` and the version Zebra currently uses (`0.13.0`) allow for plaintext lead bytes of `0x01` or `0x02` during the grace period, see: - [latest version](https://github.com/zcash/sapling-crypto/blob/main/src/note_encryption.rs#L401)...

Add semantic block validation during the ZIP-212 grace period after Canopy activation

Let's wait until Zebra is using `zcash_primitives` `v0.14.0` and then pass `Zip212Enforcement::On` in the call to `try_sapling_note_decryption()` in `zcash_note_encryption`

Add a `disable_peers` field to `testnet::Parameters`

> @arya2 is this still necessary? No, returning an empty set from the `zebra_network::Config::initial_peers()` method on Regtest is fine, at least for now. It could be useful for creating isolated...

Agree on a sketch of the overall wallet architecture

Updated temporary diagram based on recent discussions (see note at the end about the block explorer use case): ```mermaid flowchart subgraph Zcash_P2P_Network Other_nodes end Other_nodes -- chain state --> FullValidator...

lightwalletd does not parse zebrad.toml

> I wasn't aware of this, would it be helpful if lightwalletd did support the `zebrad.toml` file format? That seems reasonable; I could make that code change if it would...