Juanpe Bolívar comments

Results 344 comments of


                                            Juanpe Bolívar

Thread safety issues in free_list_heap

Cool. In any case I'm grateful for the thorough investigation of the issue.

Possibly address unused parameter/variable warnings

Makes sense, but this is low priority, since unused parameter warnings provide not much value in my opinion. You can work around it by including the library in path with...

Add a keys() method to immer::map.

Hmm, that is possible and a good idea. But be aware that the type of the return can not be `set`, that would require some kind of non-cost-free type erasure....

Add a keys() method to immer::map.

You're right about values.

Defining a security vulnerability notification strategy

Hi @mrdewitt, Just a quick message to note that this is on my radar! I am however waiting for some external input to decide on the best approach for this....

Add optional weights to rrbtree and flex_vector

Hi @jeffplaisance! Thanks for the suggestion. I do think that this is indeed an interesting feature. If this is for a commercial project, maybe we could agree on a development...

Add constructor for box<T> from box<Y> for compatible Y

Hmmm, I find the suggestion interesting, but I'm not sure supporting sharing in this case (instead of slicing) justifies the added complexity. In any case due to immutability the two...

Add constructor for box<T> from box<Y> for compatible Y

Hi! Sorry for the late reply, I was on vacation :) I see, that is a bit of an unorthodox design, I am unsure yet what the full consequences of...

Add custom allocator with precise garbage collector

Yes, I am aware that libgc is not the only approach :) I think that integrating a different GC though would need some work on immer side, because the current...

__has_feature may not be accurate

@chuim, what do you think the best solution is here?