Pavel Kutáč

Results 50 comments of Pavel Kutáč

This issue should be closed, as #1064 is merged

I wanted to try out to implement this rule, but I have a feeling it is not possible with Revive. It would require `reflect` package, or something more advanced. Because...

> There are some cases for which initialization without names should be allowed: empty structs and structs with only one field. This might need access to the definition of the...

@ccoVeille I agree with you. But as I said above, you are not able to implement that rule only on top of AST. You need some static analysis in order...

@alexandear thank you for your comment. I totally missed that one. I think it is not possible with Revive as I wrote above. Revive works only with AST, while I...

@denisvmedia Good point, it really does what I would like to have. The issue is, it skips local types. Meaning types defined in the same package. So before jumping into...

I see the #1003 was merged, however no release was made since then. Can you please release new version so we can use this feature with GolangCI-Lint? Thank you

Based on https://github.com/mgechev/revive/releases/tag/v1.4.0 it should be released. I guess this issue can be closed.

I tried with invalid token, because that is what we use. So with this workflow ```yaml - name: Slack Notification id: slack_notification uses: slackapi/slack-github-action@91efab103c0de0a537f72a35f6b8cda0ee76bf0a # v2.1.1 - https://github.com/slackapi/slack-github-action/releases with: token:...

@zimeg sure, I checked code quickly and it seems logger is initialized, but never actually used. So improving logging in general might be a good too.