Pavel Kutáč

Results 50 comments of Pavel Kutáč

@nicksnyder thanks for the reply. I will need to test it out. It should work as you described it, but I'm not 100% sure as our trigger is `repository_dispatch`, not...

It is not required actually. I have Github Actions extension in VS Code and it complains about it too. But we don't use that and it works. So I think...

We are facing same issue. The problem is in `keyset.NewManagerFromHandle` because in v2.2.0 it created shallow copy, but in v2.3.0 it creates deep copy of keys. So you are adding...

> We are aware of this. We noticed that the manager doesn't do a deep copy of the handle it returns, and considered this a bug. I'm not sure if...

Is there anything I can do to make this PR to be merged?

Thank you for your feedback. I totally understand you want to keep that behavior, and your concerns with embedding can lead to hell in the future. However what I'm building...

Could you please check PR #1426 which is handling this issue. So at least we can move further with the discussion? Thank you 🙏

Still valid. Went the same path as @preslavmihaylov I was debugging the code to see where the issue happen. 1. The Invoker returns error, which is handled by the defer...

I'm using `protocol.ResultACK` just as the owner of the ticket. Yes, I read your message: > IIRC, this one is supposed to be used by the underlying protocol (senders/receivers) to...

Yes, you are right. If you search deeper, you notice it is fulfilling `error` interface. But if you check just doc block of function and intellisense in IDE suggest you...