Kevin Arvai
Kevin Arvai
Hi @MitchellAcoustics, thanks for checking out the repo. The x and y values are interpolated and normalized before they are transformed, so it should handle the issue of unevenly spaced...
Thanks for the PR @JimPrudent. My Travis CI was outdated, so the unit tests weren't run in the Travis environment. I think I've fixed the issue. I checked out your...
This seems like a good use case to set `online=True`. [The documentation](https://kneed.readthedocs.io/en/stable/parameters.html#online) discusses how setting this will alter the identification of knee points by self-correcting and avoiding local maxima. I...
Well summarized, thanks for considering the request 😄
Could use this if you need a workaround: `databricks jobs run-now --job-id 1234567891011121 --notebook-params "$(cat path/to/params.json)"`
Thanks for the PR @vhu43, I'll be able to spend more time with it later this week. I'm concerned because there is a syntax error on line 245 (missing parenthesis)...
I think we need to update the threshold logic. Do you want to try updating [this code block](https://github.com/vhu43/kneed/blob/492d89a25305ccfa628afbdca152d648ac221e54/kneed/knee_locator.py#L288-L302), to be: ```python knee = self.x[threshold_index] norm_knee = self.x_normalized[threshold_index] ``` Then, to...
Thanks for reporting this. It looks like making the changes discussed [here](https://github.com/arvkevi/kneed/pull/142#issuecomment-2068015230) addresses this issue.
Thanks for offering to help. Unfortunately, I won't be able to release a new version soon. I need to make sure any breaking changes are identified and handled, and that...
Hi Daniel, Thanks for checking out the repo. There are two things to consider when training a new model from this Dragen dataset. 1. I wrote parsing functionality to process...