Arvid Norberg
Arvid Norberg
this is what I get on a Mac M1: rust implementation: ``` sha256_hash/hash_benchmark time: [619.71 µs 621.33 µs 623.79 µs] ``` with openssl: ``` sha256_hash/hash_benchmark time: [310.09 µs 310.47 µs...
there's still a clippy failure. the `README.md` has instructions on how to set up `pre-commit`
I also don't see what the value is in reducing these cycles. Are they preventing some other, more tangible, improvements?
test coverage: ``` chia/wallet/trading/offer.py (92.3%): Missing lines 689 chia/wallet/wallet_spend_bundle.py (96.8%): Missing lines 41 ``` @AmineKhaldi The `debug()` function has no test. Perhaps we don't care enough to test it, since...
I think it might make sense to land this through the failing test.
@aqk I think we should hold off on this until we have better test coverage
we expect this to be slower, right? I think this change needs some justification and maybe profiling.
now that we've realized that `height_to_hash()` returns `None` rather than raise an exception, I don't think we need this patch anymore
@matt-o-how there's a problem with the rust implementation. `get_conditions_from_spendbundle()` doesn't take the *bytes* size into account when returning the cost. It needs to do something like this: https://github.com/Chia-Network/chia_rs/blob/main/crates/chia-consensus/src/gen/run_block_generator.rs#L81-L84 ``` let...
sorry for the delay