clvm_rs icon indicating copy to clipboard operation
clvm_rs copied to clipboard

add black box marker to hash benchmark

Open jack60612 opened this issue 1 year ago • 8 comments

jack60612 avatar Jul 14 '24 22:07 jack60612

performance stayed the same.

jack60612 avatar Jul 14 '24 22:07 jack60612

Pull Request Test Coverage Report for Build 10226110934

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 94.075%

Files with Coverage Reduction New Missed Lines %
src/allocator.rs 4 98.11%
<!-- Total: 4
Totals Coverage Status
Change from base Build 9895604796: -0.08%
Covered Lines: 5779
Relevant Lines: 6143

💛 - Coveralls

coveralls-official[bot] avatar Jul 14 '24 22:07 coveralls-official[bot]

@jack60612 cargo fmt is failing

arvidn avatar Jul 26 '24 20:07 arvidn

this is what I get on a Mac M1:

rust implementation:

sha256_hash/hash_benchmark
                        time:   [619.71 µs 621.33 µs 623.79 µs]

with openssl:

sha256_hash/hash_benchmark
                        time:   [310.09 µs 310.47 µs 310.92 µs]
                        change: [-50.029% -49.924% -49.824%] (p = 0.00 < 0.05)
                        Performance has improved.

arvidn avatar Jul 26 '24 20:07 arvidn

@jack60612 cargo fmt is failing

oh i missed this

jack60612 avatar Aug 03 '24 06:08 jack60612

changed my config to auto run fmt

jack60612 avatar Aug 03 '24 06:08 jack60612

there's still a clippy failure. the README.md has instructions on how to set up pre-commit

arvidn avatar Aug 20 '24 08:08 arvidn

'This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed.'

github-actions[bot] avatar Oct 19 '24 11:10 github-actions[bot]