add black box marker to hash benchmark
performance stayed the same.
Pull Request Test Coverage Report for Build 10226110934
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
- For more information on this, see Tracking coverage changes with pull request builds.
- To avoid this issue with future PRs, see these Recommended CI Configurations.
- For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
Details
- 0 of 0 changed or added relevant lines in 0 files are covered.
- 4 unchanged lines in 1 file lost coverage.
- Overall coverage decreased (-0.08%) to 94.075%
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| src/allocator.rs | 4 | 98.11% |
| <!-- | Total: | 4 |
| Totals | |
|---|---|
| Change from base Build 9895604796: | -0.08% |
| Covered Lines: | 5779 |
| Relevant Lines: | 6143 |
💛 - Coveralls
@jack60612 cargo fmt is failing
this is what I get on a Mac M1:
rust implementation:
sha256_hash/hash_benchmark
time: [619.71 µs 621.33 µs 623.79 µs]
with openssl:
sha256_hash/hash_benchmark
time: [310.09 µs 310.47 µs 310.92 µs]
change: [-50.029% -49.924% -49.824%] (p = 0.00 < 0.05)
Performance has improved.
@jack60612
cargo fmtis failing
oh i missed this
changed my config to auto run fmt
there's still a clippy failure. the README.md has instructions on how to set up pre-commit
'This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed.'