Arvid Norberg

Results 1037 comments of Arvid Norberg

There's a fair amount of work involved in updating to the new boost.asio API. The simple parts are: * `io_service` -> `io_context` * `io_service::post(...)` -> `post(ioc, ...)` * `io_service::reset()` ->...

I someone volunteers a patch to update boost, I'll make an `RC_1_3` branch

a python file is about as easily updated as a yaml file.

This boils down to making `session_handle::post_torrent_updates()` efficient. I've tried to make it only post updates for torrents that actually have something new to report. These counters, that constantly count-up, are...

Your patch will make the torrent be included in updates every second. Even if the smoothed download rate stays at zero. I think the torrent would have to remember the...

`want_tick()` will return false once the torrent becomes inactive. That won't happen right away though, I don't think. Thinking a bit more about this, I would actually expect the existing...

I meant to apply that change further down, the same code your patch removes. ```diff --- a/src/torrent.cpp +++ b/src/torrent.cpp @@ -10323,8 +10323,13 @@ namespace { set_need_save_resume(torrent_handle::if_counters_changed); // if the rate...

I believe this happens when the file being renamed has not been created yet (because nothing has been downloaded to it). This case is currently treated the same as adding...

oh, it also happens because if `rename()` fails, we fall back to `copy()`

https://github.com/arvidn/libtorrent/pull/8028