Erik Arvidsson

1. Set successCallback.[[Load]] to load. EvaluateLoadedModule does not have an internal slot called [[Load]].

1. Let binding be the result of calling the ResolveExport abstract operation passing def.[[Module]] and def.[[ImportName]] as arguments. Needs to pass visited too.

In LinkDeclarativeModules ( loads, loader ), step 3.c.iv.1 1. Let module be the result of calling the LoaderRegistryLookup abstract operation with arguments loader and normalizedName.

Missing completion values

1

All the productions in the spec have "Runtime Semantics: Evaluation" which includes speccing what the completion value is.

There are some types that are copied from Replicache. For example: https://github.com/Braden1996/react-native-replicache/blob/a7b37b49ea4199e58f4262d83c19da17f2f6867b/packages/deep-freeze/src/json-value.ts#L2 This should be able to use the exported types directly to prevent copy/paste but also to ensure same...

Instructions for running the tests

2

I have postgres.app installed and running on port 5432 but there seems to be something else that I need to do to verify that things work as expected? I also...

I was browsing the `@badrap/valita` symbols and the generated API docs and I see a lot of symbols are not linked/documented. For example: https://jsr.io/@badrap/valita/doc/~/ArrayType#method_func_0 ``` func(arr: unknown, flags: number): RawResult...

fix: Reuse EntityQuery instances

3

Now we see if there exists a EntityQuery that matches the AST. If so, we return that. To ensure we do not leak EntityQuery objects, the EntityQuery is referenced through...

Things like `get` etc should generate readonly types.