Arun George

Results 11 comments of Arun George

> Can you check if build is OK with removing liburing package? FdpNvme.cpp is not protected for this case. I guess you want to bring them under -DCACHELIB_IOURING_DISABLE, right?

> Can you check if this compiles in supported platforms here https://github.com/facebook/CacheLib/actions? As per the status, 'This workflow is awaiting approval from a maintainer in https://github.com/facebook/CacheLib/pull/277' Could you check it...

> Overall looks good. Thanks for the work. > > Could you apply below patch? > > ``` > diff --git a/fbcode/cachelib/navy/common/TARGETS b/fbcode/cachelib/navy/common/TARGETS > --- a/fbcode/cachelib/navy/common/TARGETS > +++ b/fbcode/cachelib/navy/common/TARGETS >...

It is a case liburing library (which the FDP support is dependent on for now) is not available on the system, and the cachelib build system chose not to install...

Building and installing iouring from source looks to be working. The following is a method which works for FDP. git clone https://github.com/axboe/liburing.git -- Follow build process in the Readme -...

Hi @FletcherAtFADU , >> 1. WAF Expectation for KVCache You might have selected a kvcache workload without BH enabled. Could you please check the "navyBigHashSizePct" in the config.json file of...

@FletcherAtFADU >> I think 'navyBigHashSizePct' must absolutely not be zero! Is this correct? Yes, it should be non-zero for BigHash enabled cases. (I see that you have used test_configs/ssd_perf/kvcache_l2_wc/ which...

@gaowayne Please find the sample FDP config used with kvcache production traces. "cache_config": { "cacheSizeMB": 20000, "cacheDir": "/root/cachelib_metadata-1", "allocFactor": 1.08, "maxAllocSize": 524288, "minAllocSize": 64, "navyReaderThreads": 72, "navyWriterThreads": 36, "nvmCachePaths": ["/dev/nvme0n1"],...

@FletcherAtFADU It is great to know that you are able to re-produce the results. >> Can we adjust the parameters to allocate more RUs per NS or set it up...

> > @arungeorge83 @gaowayne Thanks to your help, we achieved proper evaluation results after enabling FDP. Using the KV Trace evaluation with arungeorge83's provided config worked perfectly. ![image](https://private-user-images.githubusercontent.com/168962082/332106786-4e10b243-a911-43a5-b567-dbadd30c2437.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk4MDgxMDQsIm5iZiI6MTcxOTgwNzgwNCwicGF0aCI6Ii8xNjg5NjIwODIvMzMyMTA2Nzg2LTRlMTBiMjQzLWE5MTEtNDNhNS1iNTY3LWRiYWRkMzBjMjQzNy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzAxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcwMVQwNDIzMjRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xODBkYWE2NTczN2U4YWI2MDJjNGU1NWY1NmYzMzcyYWRjNTA5MDY1N2QwNjQzNzM4ZTBmZjBkMjE1NjUwYzIxJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.qBpr19of_YFa6n0N_ymeEEmtP5utBYHMNyPvllo2f4I) > >...