Artūras Šlajus
Artūras Šlajus
I also think the debug logs should be left there, they are useful when, well, debugging :)
Is there any downside in only having the sharded implementation?
> I pushed a draft version of such an implementation, but i needs some more work on the effectful state changes from `Starting` to `Active` and from `ShuttingDown` to removal...
Taking this on. Will make it configurable via mill frontmatter.
Sorry for delaying the request for so long. Was busy, then got sick. I hope to review this this week.
I'm taking this on.
> Our BSP implementation should already be able to decide whether compile or semanticDbDataDetailed is needed. I don't think it does? I am on my phone now, but it seems...
https://github.com/com-lihaoyi/mill/blob/8d204315655e510d2fcd3c48dc431b09be474daa/libs/javalib/src/mill/javalib/bsp/BspJavaModule.scala#L135-L143 invokes https://github.com/com-lihaoyi/mill/blob/007f75c8ae343a9fbbafd77dcb1779acde82882c/libs/javalib/src/mill/javalib/RunModule.scala#L78-L83 which invokes https://github.com/com-lihaoyi/mill/blob/ca6e3f9cb070c1e860b8b261bd7559658f70d323/libs/javalib/src/mill/javalib/JavaModule.scala#L923-L930 which invokes https://github.com/com-lihaoyi/mill/blob/ca6e3f9cb070c1e860b8b261bd7559658f70d323/libs/javalib/src/mill/javalib/JavaModule.scala#L844-L881 which invokes https://github.com/com-lihaoyi/mill/blob/ca6e3f9cb070c1e860b8b261bd7559658f70d323/libs/javalib/src/mill/javalib/JavaModule.scala#L975-L980 So it seems like it doesn't compile things with semantic db. From discussion with @lihaoyi: > the whole...
> In the meantime, please have a look at issue [#1546](https://github.com/com-lihaoyi/mill/issues/1546), where I outlined three different ways to realize semanticDb support without sacrifying Mill's consistency. Thanks for the write up....
> It would also be interesting, to find out why the Scala 3 with semanticDB toolchain no longer works with the `-Ystop-after:semanticdb-typer` options, since this was IMHO the best solution....