Artūras Šlajus
Artūras Šlajus
Looks good to me! ---- On Sat, 09 Nov 2024 13:16:10 +0200 Nikita Gazarov ***@***.***> wrote --- https://github.com/arturaz Thank you for working on this, and for the patience! I've merged...
I believe it was due to `closed` not being volatile: https://github.com/com-lihaoyi/os-lib/blob/638ae3b2c078564d5122aca4b06ed30b03d9f097/os/watch/src/FSEventsWatcher.scala#L14 Then if `close()` was invoked multiple times, `current` and `dummyCfString` was released while pointing to invalid memory because other...
To be honest, I have no idea, but this is the closest to a reasonable explanation I could come up. I think we should try it with the new os-lib...
You mean the whole JVM process stops? What is the exit code when it does that?
Is there any infrastructure for this already? For example, does `mill init` entry point exists?
I'll try to implement this :)
I am working on it right now (fell ill with COVID after starting it). Could you give me a couple of days to finish it? 🙂 ---- On Mon, 23...
> @arturaz Would you like some help with completing it? I'm not sure how that'd work, at least right now, but I will keep that in mind!
Hey @llvee. I think you should take over this. I've pushed what I've done to https://github.com/arturaz/mill/commit/3bcf83464353e57f3251df13c8fa94f10e92974d , feel free to use any or none of it. I've hit a bump...
> I was somewhat worried about contention on a single AtomicCell holding all subscriptions (but it could be completely unfounded). Yeah, this needs to be benchmarked. We could be complicating...