Abdul R. Tay

Results 14 comments of Abdul R. Tay

@bluepnume the render method by default uses an iframe. Forcibly passing the context constant not only overrides the defaultContext option on the component's definition but also makes the docs misleading...

It is quite clear by the name `defaultContext` that if you don't specify `context` to `render` method, then it **should** use the `defaultContext` in my component's definition unlike the current...

you understand my point correctly. When using the driver pattern, the app cannot control the `context` in `render` method as it is using a constant value (iframe) instead of `defaultContext`...

Yes. Currently it enforces an iframe: https://github.com/krakenjs/zoid/blob/eb8677a3c41f8ad52158ad946573d0df9a47538d/src/drivers/vue.js#L62

That's a fair work around. Regardless of how it should be done, the defaultContext value should be coming from component's definition instead being hard coded as it currently. The default...

My use case is I cannot render a popup using the driver pattern as it forces an iframe over component definition options. The code that I am targeting is only...

That is an artifact. It's not always the case. My browser on the other hand allows popup by default. I want the React driver to adopt `defaultContext` option from my...

![Screenshot 2022-03-01 at 12 00 42 PM](https://user-images.githubusercontent.com/28489704/156120599-e8e1e98a-b053-4217-a71a-4bab8f9d787c.png) It is an artifact because this behavior is a result of 1. User's browser preferences 2. How the app triggered render on driver...

This sounds like an over generalisation to optimize user experience essentially by handicapping the app to render a popup when using the driver (More at end). The current design violates...