Tuomas Artman comments

Results 10 comments of


                                            Tuomas Artman

iOS tutorials contain error

The tutorials project README's incorrectly stated that the project for tutorial 2 is the end result of tutorial 1. This isn't true and has been fixed. Additionally, there seems to...

iOS tutorials contain error

@Byku, please do.

iOS tutorials contain error

@Byku happy to help to get your fixes over to the wiki. You can clone the wiki source from `https://github.com/uber/RIBs.wiki.git`.

Pass observer to the callback closure, to avoid retain cycle or [weak self] boilerplate

This would work and some might prefer it, but I do like the bare bones closure approach. This would work even better if you could name observer as "self", overriding...

Pass observer to the callback closure, to avoid retain cycle or [weak self] boilerplate

For sure!

ResetFireCount method. Fix clearLastData documentation.

Looks good, but Travis doesn't seem to find the iPhone 6 simulator anymore. I'll have to take a look unless you want to?

Proposal: Read Only Signal

Yeah, I've never liked the fact that the fire method is exposed to potential observers. However, I also would't like to overcomplicate the construction of a Signal too much or...

Proposal: Read Only Signal

For sure!

Migration performance correlated to number of migration files

We actually solved these problems by adding the `--transpile-only` ts-node flag to the npm script that runs the migrations. Reduced our run time ten-fold and is pretty safe as you...

feat(auth): add support for function for password

Yes please.