Arthur Lee

Results 115 comments of Arthur Lee

@Oppen Hi I have a question about `ra_advance_until(const roaring_array_t *ra, uint16_t x, int32_t pos)`, it seems this will jump over the container position `pos`, which means if you want to...

I have a new update on this, please take a look.

> Looks mostly OK. We still need tests and documentation, and benchmarks would be desirable too. @lemire what did you mean by header version BTW? OK I will add this...

benchmarking testing result on my MacBookPro ``` ./containsmulti_benchmark ../../benchmarks/realdata/weather_sept_85/* Data: cardinality: 1015367 Cycles/element: roaring_bitmap_contains: 20.309929 19.774353 49.094340 22.242483 20.091069 roaring_bitmap_contains_multi: 19.149179 19.673742 38.943396 21.253152 20.512871 roaring_bitmap_contains with sorted input: 15.373762...

seems CI did not works well on Arm arch

> Please review the related PR #363 It looks good to me, and I'm sure this would benefit us a lot. I will do some benchmarks later.

> @arthurkiller Presumably, you did run the benchmarking code that you wrote and contributed. Can you share your results? ``` bash Data: cardinality: 1015367 Cycles/element: 10 roaring_bitmap_contains: 14.055272 14.159930 48.363636...

> @Dr-Emann You can check the benchmark result above. Sorted data can enhance the performance by about __10%__. But this result did not count the time `QSort` spent (even though...

> @arthurkiller I'm not sure where sorting came in. I was talking about taking this from `roaring_bitmap_contains_multi(bitmap, count, values[], results[])` to something like `roaring_bitmap_contains_bulk(bitmap, &context, value) -> bool`, where context...

> @arthurkiller I'm not sure where sorting came in. I was talking about taking this from `roaring_bitmap_contains_multi(bitmap, count, values[], results[])` to something like `roaring_bitmap_contains_bulk(bitmap, &context, value) -> bool`, where context...