nft-contracts

nft-contracts copied to clipboard

TODO: still requires forking mainnet to run tests ``` FORK=true hh test ```

caffeinum

caffeinum

erc20 token pass extension

1

Feature request: Allow to mint specific ERC20 holders that has min balance. **Warning!** No protection against transfer-and-mint

caffeinum

metaverse-nft: not allow contract to call mint()

4

_speculative._ https://www.reddit.com/r/ethdev/comments/8r6b93/is_txorigin_msgsender_a_secure_option_to_prevent/ TODO: - [ ] estimate how many users minted using multisig - [ ]

caffeinum

NFTExtension interface conformance doesn't check anything

1

Given `INFTExtension` interface is empty, the ERC165 check for that is always true. https://github.com/buildship-dev/nft-contracts/blob/2f33f71c05266b45b1f1e3fb80e421087dd8f5b7/contracts/factory/extensions/INFTExtension.sol#L6-L7 Which means `addExtension` check doesn't check anything: https://github.com/buildship-dev/nft-contracts/blob/2f33f71c05266b45b1f1e3fb80e421087dd8f5b7/contracts/factory/MetaverseNFT.sol#L201-L205

caffeinum

Floating Pragmas

2

Not a problem, but a lousy solidity's code practice, Every contract has a floating `pragma` which is not recommended. It should be fixed. Fix the Pragmas Additional context: Check this:...

ShaheenRehman

**Floating pragmas are considered a bad practice.** It is always recommended that `pragma` should be fixed (not floating) to the version that you are intending to deploy your contracts with....

ShaheenRehman

caffeinum

Trigger OpenZeppelin Report

2

caffeinum

Deployment/zksync factory

1

caffeinum