metaverse-nft: not allow contract to call mint()

[caffeinum]

speculative.

https://www.reddit.com/r/ethdev/comments/8r6b93/is_txorigin_msgsender_a_secure_option_to_prevent/

TODO:

• [ ] estimate how many users minted using multisig
• [ ]

[codecov[bot]]

Codecov Report

Merging #57 (3ef1b52) into main (bb6442e) will increase coverage by 0.30%. The diff coverage is 94.11%.

@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   45.74%   46.04%   +0.30%     
==========================================
  Files          20       21       +1     
  Lines        1080     1088       +8     
  Branches      163      167       +4     
==========================================
+ Hits          494      501       +7     
- Misses        586      587       +1     

Impacted Files	Coverage Δ
contracts/MetaverseNFT_ERC721.sol	0.00% <0.00%> (ø)
contracts/MetaverseBaseNFT.sol	73.15% <100.00%> (+0.18%)	:arrow_up:
contracts/MetaverseBaseNFT_ERC721.sol	72.97% <100.00%> (+0.18%)	:arrow_up:
contracts/MetaverseNFT.sol	86.27% <100.00%> (+0.09%)	:arrow_up:
...racts/extensions/LimitedSupplyMintingExtension.sol	100.00% <100.00%> (ø)
contracts/extensions/mocks/MockProxyMinter.sol	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bb6442e...3ef1b52. Read the comment docs.

[theshadowagent]

Wow this is so good

[theshadowagent]

It will drop the multisig minting. Is this bad for communities?

[theshadowagent]

It might be actually better since it guarantees that the holders are actual people - community members. I wonder if this should be an extra setting?

[caffeinum]

come back to this later, optionally include this as an extension