Artem Labazov comments

Repositories
Issues
Comments

Results 5 comments of


                                            Artem Labazov

Avoid iterator invalidation without effective insert

PS: docs also say that `erase()` always invalidates the iterators, though the current implementation does that only on effective erase. Should the doc be adjusted as well?

Avoid iterator invalidation without effective insert

Thanks for the feedback. I have pushed fixes for review and additionally reverted `+ 1` in load threshold check to preserve original behaviour

Avoid iterator invalidation without effective insert

I think I have addressed all of your comments in the last revision and it is safe to merge. Also, I have squashed all the commits into a single one...

librdkafka cannot be built with LLD linker

cc @emasab

librdkafka cannot be built with LLD linker

FreeBSD seems to be affected as well: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275866