art-w

Results 105 comments of art-w

Ok sure, I'll add the `?eq` parameter: it's what [React](https://erratique.ch/software/react/doc/React/S/index.html) does, so there is a precedent! I liked the `cutoff` function as a way of keeping the other operations "simple...

Ooh right sorry, I missed the `overapproximate` optimization! Indeed it calculates the right lowerbound (= `now`), but then it searches from 2022/01/01 until today. Maybe it's because the pattern enumeration...

That was fast! Thanks a lot, it's much appreciated :) I'm not impacted by the following, but after reading and thinking about the code, I believe there's an interesting edge...

Yes it works! Thanks a ton, I'm a big fan of your reactivity and I'm very happy of how easy the cron scheduling turned out be thanks to timere! Have...

Yes the git pin is great! There's absolutely no need to rush, please take your time :)

> Do you know how big the sorted file is? You say it is large, so it's very nice that this PR eliminates this disk usage! Oh sorry for the...

It would break everything yes! But it is the new mapping file before it becomes visible and used by anyone :)

In case it helps to identify the issue, on the [offending line](https://github.com/mirage/irmin/blob/main/examples/irmin_git_store.ml#L23) reported by @Zineb-Ada , it gets faster when locating the submodules: ```ocaml module Store = Irmin_unix. Git. FS....

@voodoos > We'll soon be able to run the benchmarks only for PRs that have been marked with a specific github label: for example "bench", but you just have to...

Ha I see, thanks for the pointer! Unless there are more reports of servers rejecting this header, I don't think it's a pressing issue :P