Matt Arsenault
Matt Arsenault
Patch title is now less clear, this is DAG codegen support
> * [ ] Add the support for dropping nsw/nuw flags to `llvm-reduce` > I've already implemented this but haven't had working internet to push it
> The comment is for documentation. I have to check optionals. I will never read from an optional before checking. I say remove them, and/or introduce a cannot fail API
> I can remove the comments. The alternative would be to pass the `G_CONSTANT` s as MachineInstr to the match function and then manually extract the immediate, but this is...
> I can remove the comments. The alternative would be to pass the `G_CONSTANT` s as MachineInstr to the match function and then manually extract the immediate, but this is...
I don't think you can reasonably test this with a lit test, you have to add this as a proper build target in llvm/examples similar to Bye
> I don't think you can reasonably test this with a lit test, you have to add this as a proper build target in llvm/examples similar to Bye. A lit...
This also came up recently in https://github.com/llvm/llvm-project/pull/139769
> If something goes wrong, we can revert it. However, I've tested and tested this and found no issue. This isn't really the point of adding tests.
> `isVCC` is used in a number of other places, e.g., inside `selectG_UADDO_USUBO_UADDE_USUBE()`. In those other contexts apparently they don't consider "the other" reg. I don't know if there even...