Oleksandr Krutko

Results 35 comments of Oleksandr Krutko

Any progress with this issue? I would like to tackle.

> @arsenalzp You may add missing unit tests under the runtime module. Hello, I took some unit tests, however I guess my project was not configured properly because even already...

> @arsenalzp > > > JVM version : 17.0.8+7 > > Please retry using JDK8. If you're still encountering problems, it may be a potential bug and it's welcome to...

Hello, If you need help with this bunch of tasks, I kindly help you with that!

The issue is that the certificate pool is created for each source, so it is necessary to maintain it for each bundle and it should be persistent. Let's discuss this...

This [code](https://github.com/cert-manager/trust-manager/blob/cd860d6da4580e9aa1d193b33d726e4a01ad3af0/pkg/bundle/sync.go#L85) process each source separately, however `util.ValidateAndSanitizePEMBundleWithOptions()` should accept either all sources or just hashes only, to be able to maintain hashes across invocation.

> A simple POC shows that > > ``` > // NB: empty bundles are not valid so check and return an error if one somehow snuck through. > >...

I tried to fix this issue with no harm to the existing code and test. It is reasonable to separate a sanitizing and a deduplication processes, instead to develop huge...