Gleb Popov
Gleb Popov
@bombela Can you please take a look at this PR? It is a trivial one.
AFAIK, yes.
> Also, there are some lines over 80 characters wide. These are all just ";" or ");" standing out and I thought it isn't a big deal. Should I fix...
Oh, I get it - I have 4-character tabs set in my editor. I now changed it to 8 according the style and see all the problems.
Should be good now.
Merged, thanks for the thorough review.
Just to repeat my comment from #1271 - it'd be great to have both automatic `autoremove` after the package deletion as well as what PackageKit calls a recursive deletion: a...
Then the bug is on the freebsd-src side. I'll look into `git blame` to figure out why that line is wrapped into `.if defined(PACKAGE_BUILDING)`
The `.if defined(PACKAGE_BUILDING)` change in src tracks back to https://reviews.freebsd.org/D42569 I'm now confused how this condition could ever be true if you say that `-b` should not set it. My...
No, it is the other way around - I want `PACKAGE_BUILDING` to be set so that that condition will fire.