freebsd-src icon indicating copy to clipboard operation
freebsd-src copied to clipboard

Exterrorize fuse_vnops.c

Open arrowd opened this issue 6 months ago • 2 comments

Next chunk of work on exterrorizing fuse code. Putting this on GitHub, because I divided changes into many commits - one commit per VOP. I will squash these commits before merging.

@asomers please take a look.

arrowd avatar Jun 17 '25 18:06 arrowd

What's the state of userland support for this? Is ktrace still the only way to see the extended error codes?

asomers avatar Jun 27 '25 18:06 asomers

AFAIK, yes.

arrowd avatar Jun 27 '25 18:06 arrowd

Also, there are some lines over 80 characters wide.

These are all just ";" or ");" standing out and I thought it isn't a big deal. Should I fix all the GitHub Actions warnings listed in the "File changes" tab?

arrowd avatar Jun 28 '25 20:06 arrowd

Also, there are some lines over 80 characters wide.

These are all just ";" or ");" standing out and I thought it isn't a big deal. Should I fix all the GitHub Actions warnings listed in the "File changes" tab?

I normally take a hard line about 80 characters and trailing white space. But I don't usually pay much attention to any other GitHub Actions style warnings.

asomers avatar Jun 28 '25 22:06 asomers

Usuall the checker is pretty good. However this file has a number of variant style things that it flags that shouldn't be fixed since it makes some of the code not match and seems like too much churn. Line lengths have been moving toward 100 so if it's just a couple of characters over, I usually don't worry about it... but for this file, Alan wrote it, so a stricter adherence to the 80 rule seems warranted based of the match the existing style preference we have.

Clear as mud, eh? Tl;dr: do 80 cols, ignore return paren rule, but fix the rest.

bsdimp avatar Jun 28 '25 22:06 bsdimp

Oh, I get it - I have 4-character tabs set in my editor. I now changed it to 8 according the style and see all the problems.

arrowd avatar Jun 29 '25 17:06 arrowd

Should be good now.

arrowd avatar Jun 30 '25 08:06 arrowd

Merged, thanks for the thorough review.

arrowd avatar Jul 04 '25 07:07 arrowd