ggd icon indicating copy to clipboard operation
ggd copied to clipboard

Comments on example command

Open sjackman opened this issue 11 years ago • 8 comments

python ggd.py

Install a ggd shell script and use instead ggd install …?

ucsc.human.b38.cpg

The underlying URL of the formula uses slashes to separate components. Why use dots here? Consider instead ucsc/human/b38/cpg.

human

Common names are ambiguous. Use binomial names instead?

b38

Use the full name GRCh38 instead?

source.species.genomebuild.name

Perhaps this format could optionally include the GitHub username and repo to support installing formula from non-arq5x/ggd-recipes locations.

user/repo/source/species/genomebuild/name

sjackman avatar Dec 04 '14 22:12 sjackman

Yep, good points!

  1. I will make it an executable Python script. Just haven't gotten to it yet.
  2. Worth considering, though I was fearful of confusion with real directories.
  3. I see your point. This requires some thought...
  4. The --cookbook option (no examples yet) allows for this.

arq5x avatar Dec 04 '14 23:12 arq5x

The --cookbook option (no examples yet) allows for this.

I've found with Homebrew that its nice to include the cookbook in the identifier. For example, brew install homebrew/science/abyss fetches the formula https://github.com/Homebrew/homebrew-science/blob/master/abyss.rb.

sjackman avatar Dec 04 '14 23:12 sjackman

Worth considering, though I was fearful of confusion with real directories.

It's really nice to be able to paste from the terminal/command line into the browser location without having to change all the dots to slashes, which gets old really fast.

sjackman avatar Dec 04 '14 23:12 sjackman

I like that, but it is a bit too restrictive IMHO. It still assumes github as a base. The --cookbook allows things like:

--cookbook file:///path/to/recipes
--cookbook http://shaun.io/recipes

That said, if just /foo/bar/recipe are given on the CL, it could assume a github base by default.

arq5x avatar Dec 04 '14 23:12 arq5x

Yes, that's what brew does too.

saketkc avatar Dec 04 '14 23:12 saketkc

That said, if just /foo/bar/recipe are given on the CL, it could assume a github base by default.

Yes, and if a full URL is given, use that, which allows for an arbitrary non-GitHub base.

sjackman avatar Dec 05 '14 00:12 sjackman

Yep, thanks much for the feedback!

arq5x avatar Dec 05 '14 00:12 arq5x

@sjackman I agree with you and switched to slashes instead of periods to define the hierarchy.

arq5x avatar Dec 05 '14 12:12 arq5x