Andy Porter

Have now added `rank_of_subsection` to most nodes that need it. However, I need to check that I've not lost fixes that were added to the old _array_notation_rank() method in fparser2.py....

It would also be good to handle the case where a WHERE contains references to arrays without any subscripting.

Thanks for reporting this @mbraakhekke. Do you get the expected parse tree for the line in isolation? (I ask because you have to be careful as, unless you tell the...

It's slightly non-intuitive. You need to call set_format() on the reader object (https://fparser.readthedocs.io/en/latest/_static/html/classfparser_1_1common_1_1readfortran_1_1FortranReaderBase.html#ad9e18ea6d859fd5459381d4f1437311d) and pass it an appropriate sourceinfo.FortranFormat object: ```python from fparser.common.sourceinfo import FortranFormat reader = ... reader.set_format(FortranFormat(is_free=True, is_strict=False))...

I think I've hit a very similar bug - certainly I have a string with a backslash and fparser fails: ```fortran program a_test use some_mod ! Single met folder. L...

The `following character continuation: "'", expected None` warning came from the code that attempted to check for an inline comment. That seemed unnecessarily complicated but I do now have some...

Looking at splitquote in `common/splitline.py` I see: https://github.com/stfc/fparser/blob/3bc75feb8fe1c0f18ac352cea9c2ea173699ffb3/src/fparser/common/splitline.py#L281-L289 but this seems to be fundamentally wrong: in standard Fortran the backslash is just a standard character, it doesn't escape anything. (The...

Testing this from Python is slightly complicated as (as mentioned earlier) backslash *is* an escape character in a Python string.

I'm going to close this one as it's not really a PSyclone issue per se, more usability. We do now automatically add OMP threading where we fail to offload (see...

Thanks everyone. @reuterbal Sergi and I discussed #449 and are a bit worried that it might break a lot of things in PSyclone (and we urgently need to make a...