Jacek Sieka

the unit test suite is not written in an exception safe way - this is problematic because: * tests are often a good source of example code - if they...

async transformation doesn't handle implicit return

1

```nim proc works(): Future[int] {.async.} = return 53 proc works2(): Future[int] {.async.} = result = 53 proc broken(): Future[int] {.async.} = 53 # Error: expression '53' is of type 'int...

Rotate PeerID

5

When connecting to other peers, it is not strictly needed to reuse the same PeerID - we already rotate PeerID on restart, but keep one as long as the application...

See https://github.com/status-im/nim-stew/pull/93 - this flag helps ensure we use consistent naming of symbols across the codebase

Currently, we have a queue of 1024 pending writes in gossipsub, before we start disconnecting peers. This is somewhat arbitrary and doesn't take into account large vs small writes -...

Test coverage

2

A few areas that appeared not to trigger any test failures when refactoring the code - some may be covered partially but might need more variation: * [ ] Peer...

https://github.com/status-im/nim-libp2p/blob/17e00e642a513d21744e03f16531cc286c548721/libp2p/protobuf/minprotobuf.nim#L373 we parse type/field header into an `uint64` where in reality, https://developers.google.com/protocol-buffers/docs/proto#assigning_field_numbers says that field numbers are `

Cancellation tests

1

Cancellation is suspected of leaking resources, tests are needed for the most common cancellation paths: * [ ] cancelling a connection attempt (tcp) * [ ] cancelling a readLp /...

SOCKS proxy support

1

SOCKS proxy support would allow running libp2p over anything that support socks proxies, including for example the [tor](https://www.torproject.org/) daemon

https://github.com/status-im/nim-beacon-chain/pull/1081 removes some multiaddress parsing code that obviously doesn't belong there - it would be nice to have this in libp2p proper - ie ways to extract interesting parts from...