Jacek Sieka

Extremely slow slice assignment implementation

3

### What happened? https://github.com/nim-lang/Nim/blob/a4d63ca8ba012d4a65a66b655e98d7ea79c313db/lib/system.nim#L2619 - the current slice assignment is implemented using a `for` loop over the indices. In particular, this means that for each entry in the loop, a...

illegal declarations should give error at declaration time, not later at instantiation time

6

In the following snippet, context on line 3 has a bad type, but instead the compiler complains that line 9 is wrong: `test.nim(9, 18) Error: invalid type: 'object' in this...

`dataField` in cgen depends on undefined behavior

1

https://github.com/nim-lang/Nim/blob/160a03464310d8a9e1ffaf83d73904df3439df78/compiler/cgen.nim#L249 Like `lenExpr` this should check for null of the seq/string - in practice, it kind of works because mainly what happens is an address calculation but it's a problem...

I'm attempting to use https://app.mycrypto.com/sign-message with a Ledger-Live derived wallet (on a ledger device), but there is no "Ledger Live" derivation path option, and I'm not able to find a...

allow connecting to addresses with p2p id

7

When passing an address like `/ip4/192.168.1.106/tcp/10634/p2p/16Uiu2HAmTaEoEpEFkrCKfU5srxYrgkgBz4e2LJDhdod4VwgH2DkC` to `connect`, it should succeed to connect and verify that the peer id matches the given on. Instead, the address gets dropped here because...

mplex: streams not `reset`

1

When a handler doesn't close a stream (per #762 or because it raises an exception or any other reason), in `mplex` it makes sense to send a `reset` to the...

In protocol handlers, there's a zoo of options with regards to closing the stream after handling the protocol request: * [example](https://github.com/status-im/nim-libp2p/blob/1de7508b64e29c2bcad7a393c36cf8390a8c50fe/examples/helloworld.nim#L20) says handler must `conn.close` * [identify](https://github.com/status-im/nim-libp2p/blob/1de7508b64e29c2bcad7a393c36cf8390a8c50fe/libp2p/protocols/identify.nim#L178) uses `closeWithEOF` *...

Canonical JSON mapping

13

This PR adds a canonical JSON mapping to the SSZ specification, documenting current usage of JSON in tests, API:s and simplifying future interop work between clients and adjacent specifications such...

Opt-in metrics should not store metrics until consent is given

1

# Problem https://github.com/status-im/status-go/blob/91620b9982e930c55e29b2e3a3df574032991f33/_docs/app-metrics.md#opt-in-system The documentation states that metrics will be collected and stored before the user has opted in to do so - this creates a problematic situation where the...

Shared validator pubkey

3

This PR allows sharing the pubkey data between validators by using a thread-local cache for pubkey data, netting about a 400mb mem usage reduction on holesky due to us keeping...