Jacek Sieka

Results 667 comments of Jacek Sieka

lgtm, good to backport as well with any potential dependencies cc @narimiran

> It seems like this never worked? Asking just to make sure what triggers it now hm, the plot thickens - looks like I reduced this one step too far:...

+1, just bisected the full code to the same PR (`make NIM_COMMIT=8a4ee2b84f LOG_LEVEL=TRACE nimbus_beacon_node` in the nimbus-eth2 clone) and yeah, workaround works, but I can't say it makes sense at...

original code, for reference: https://github.com/status-im/nimbus-eth2/blob/77c36b3c59fcc02ff28d61d36897e0392c305d98/beacon_chain/spec/eth2_apis/eth2_rest_serialization.nim#L1404 the intent was to print the type of the value passed in to the serializer like so: https://github.com/status-im/nimbus-eth2/blame/77c36b3c59fcc02ff28d61d36897e0392c305d98/beacon_chain/spec/eth2_apis/eth2_rest_serialization.nim#L2285 I guess it's entirely possible that nobody...

ok - that's actually .. viable to use in a crisis and good to know, as a mechanism to delay the binding - unfortunately, it doesn't quite scale - this...

> The problem is usually in the opposite direction, Nim doesn't do enough of "magic": https://github.com/nim-lang/RFCs/issues/380 this rfc is not applicable here though - this issue is about maintaining consistent...

> I was going to PR this but maybe exposing the silent failures is better? I think it might be better to expose the problem indeed - we changed the...

what's the status of this one? it's highly interesting as migration path from refc to orc, as it makes it easier to use the same code with both collectors.

> The problem is that refc cannot handle copying of upcast of subtypes so what would be the steps from here? do you mean valid or invalid upcasts?

ooh, great stuff! :+1: from me, was hoping it would lead to this.