Jacek Sieka
Jacek Sieka
> Inability to instantiate directly gives an error instead of waiting for overloads to finish shouldn't this just cause it to not be considered? sounds similar to C++ sfinae, which...
Draft until https://github.com/status-im/nim-unittest2/pull/34 is merged
> The committee association check requires shuffling computations. The committee_index still needs to be checked but crucially, with this change we can do so _after_ signature verification meaning that only...
> The proposed change prevents (1) but doesn’t help with (2). Is this correct? the shuffling is computed from the signed fields (target / block_root depending on design), so this...
> add the explicit check broadly, the phase0 conditions still apply since they reference `index` which we replace in this PR.
> of it being "minimal" minimal here means that it does not affect the consensus spec significantly since the parts outside of the state transition are much less strictly specified...
> Wouldn't you want to update the validator spec here as well, in particular how validator constructs the attestation should use SingleAttestation? Agreed: [1c529a8](https://github.com/ethereum/consensus-specs/pull/3900/commits/1c529a858c13cccae60b69b3f35c14b02b214c69)
> Given https://github.com/ethereum/consensus-specs/pull/3900#issuecomment-2351908558 there is an impact on Web3Signer API to introduce SINGLE_ATTESTATION signing request type this is not 100% necessary - we can also translate back and forth -...
@ppopth that's more or less the outcome of applying this PR together with https://github.com/ethereum/consensus-specs/pull/3787
> API (including event stream). I would probably not change the event stream for the same reason as we left index in AttestationData - this affects a greater amount of...