Alexander Lyon

Results 241 comments of Alexander Lyon

Great! What we could do is change the error type here for `QueryStringSerialize` and `JSONSerialize`: https://github.com/arlyon/async-stripe/blob/1abab373bd6babbfaa93e473d1854208e51a8f27/src/error.rs#L13-L16 And include both the serde error _and_ the error path, rather than _just_ the...

Ah! Gotcha. In the mean time, lets just go with JSONSerialize then. I assume that that will make up the vast majority of cases in any case.

We have a benchmark in here with unknown status. It would be great to a) get that working, b) come up with a useful compile time benchmark, and c) be...

Hi! Dynamic expand values is something I didn't consider in the original design but we could probably support it if needed. Can you describe a little more about how you...

That said, having messed around with this further, the issue occurs for any fields that borrow a value which means that paginating with any borrowed params is broken. Not ideal...

For some more context, this issue appeared while trying to fix pagination, because previously pagination completely ignored any params given entirely so I'd say this is at least a step...

Until I sort out wiring these lifetimes up correctly (thanks again for the report, this is a glaring error) then the suggestions is either downgrade to 0.14 (which has the...

Thanks for the report. I'll have a look and see if we can either a) rework the deps or b) at least document this requirement.

We are planning on addressing this issue with 0.15 where we will split out the codegen into crates. This will make the dependencies much more explicit. Stay tuned.

Hi The terminal APIs are currently not exported (and untested). I will write a PR to add them and you can provide feedback. Everything should 'just work' after that. See...