ConvexBodyProximityQueries.jl icon indicating copy to clipboard operation
ConvexBodyProximityQueries.jl copied to clipboard

Integer dir gives error

Open LilithHafner opened this issue 3 years ago • 1 comments

Perhaps you don't intend to support this, but in that case documentation or a better error would be nice

julia> closest_points(polyA, polyB, @SVector[1,0])
ERROR: MethodError: no method matching eps(::Type{Int64})
Closest candidates are:
  eps() at /Applications/Julia-1.7.1.app/Contents/Resources/julia/share/julia/base/float.jl:855
  eps(::T) where T<:Dates.TimeType at /Applications/Julia-1.7.1.app/Contents/Resources/julia/share/julia/stdlib/v1.7/Dates/src/types.jl:444
  eps(::ColorTypes.Gray{T}) where T at ~/.julia/packages/ColorVectorSpace/CPykb/src/ColorVectorSpace.jl:213
  ...
Stacktrace:
 [1] closest_points(p::StaticArrays.SMatrix{2, 11, Float64, 22}, q::StaticArrays.SMatrix{2, 11, Float64, 22}, init_dir::StaticArrays.SVector{2, Int64})
   @ ConvexBodyProximityQueries ~/.julia/packages/ConvexBodyProximityQueries/RdbUo/src/proximity.jl:22
 [2] top-level scope
   @ none:1

LilithHafner avatar Dec 27 '21 00:12 LilithHafner

I derive the type from the direction vector - not sure why I did it this way instead of converting the type if it were an Int. I'll push a fix for this over the next month. Thanks for catching it.

arlk avatar Dec 27 '21 15:12 arlk