arkon
arkon
Because you need to ensure that it handles importing newer or older versions of settings. If you actually do think it's 3 lines of code, you could open a PR.
@XiangRongLin Sure! If you could detail your approach, I (and maybe others) can provide feedback. Some things to keep in mind: - Storage location settings might be problematic due to...
There is some, but those are tied to the app updates. Backups need to work across app versions. You can consider tracking setting versions in the backup itself.
For reference: https://github.com/jmir1/aniyomi/commit/e2ad7ac82c8f0eab464e2536a29f2e2b8176451f Notably doesn't handle migrations or invalid values from other versions of the app (forks, main app, etc.). It'd be ideal if whatever's implemented handles settings across forks,...
@jmir1 I believe there's a possibility of it crashing with enum values that don't exist, but it may be dependant on their usage.
I probably won't be touching the Bangumi tracker since I don't really use it, so a PR is welcome.
Sort of a duplicate of #3479. EDIT: nevermind, not really.
As mentioned in #7768: > Someone on Discord suggested adopting the J2K button between the info and chapters, along with a suggestion of showing the FAB only when that button...
This does seem sensible to be consistent with the library, but would it be better to push the share or download items into the overflow?
Do you have screenshots?