Arko Dasgupta
Arko Dasgupta
thanks for raising this, do we need to edit these to `string` instead ? The CEL validation on the `metav1.Duration` should still kick in and allow acceptable values https://github.com/envoyproxy/gateway/blob/6c6633c2a8bfc772415ea3bf68e14ef20064cb22/api/v1alpha1/healthcheck_types.go#L81
ok I see an issue we ended up using `metav1.Duration` in this API but we really should have used https://github.com/kubernetes-sigs/gateway-api/blob/962b35ea3c71ae604e0db696780c76a86b58ee17/apis/v1/shared_types.go#L765 which is used everywhere else in the project https://github.com/envoyproxy/gateway/blob/6c6633c2a8bfc772415ea3bf68e14ef20064cb22/api/v1alpha1/keepalive_types.go#L26 this...
thanks for helping us find this @nicks we'll also need to add an entry in https://github.com/envoyproxy/gateway/blob/6c6633c2a8bfc772415ea3bf68e14ef20064cb22/tools/linter/golangci-lint/.golangci.yml#L34 to make sure this doesnt happen again
@Ninir there's WIP PR https://github.com/envoyproxy/gateway/pull/4931 that I dropped the ball on, will pick up and make sure it gets into v1.4
hey @Ninir would you interested in taking #4931 forward ?
yeah @Ninir, its around making sure all API fields use `gwapiv1.Duration` instead of `metav1.Duration` . This will need to impacting three layers - `gateway-api` which reads the API field, the...
there's still a bug here, the doc string says when `unspecified or empty` , this can imply the field is optional, but rn its required
imo this is a presentation problem, can this be solved using the new CEL matches option ? https://github.com/envoyproxy/gateway/pull/3688