Arko Dasgupta
Arko Dasgupta
keeping this open to track CI work to push charts to docker hub + docs work to highlight using these charts in the upgrade steps
another decision point + extra TODOs here, is to also add the `stable` channel Gateway API CRDs in the chart, and decide which one should it default to
keeping this open to track docs work in the installation / upgrade section
chart is available in https://hub.docker.com/r/envoyproxy/gateway-crds-helm, closing this issue for now, and creating a new one to track docs work
thanks @danehans, does this test pass on any implementations ?
this test is adding conformance for this section https://gateway-api.sigs.k8s.io/guides/api-design/?h=supportedversi#supported-api-versions, if this is undesirable, then the section should be modified
@tejaboppana thanks for flagging this in step 1, did you create the `Gateway` resource first (a.) and then create a `EnvoyProxy` specifying the custom deployment name (b.) and then link...
thanks, yeah an additional item here to delete based on gateway owning labels, and not just deployment to svc name https://github.com/envoyproxy/gateway/blob/0f4cb27f0110051f7811122a2dd73652c93a15b2/internal/infrastructure/kubernetes/infra_resource.go#L402
@zhaohuabing there's additional work here of cleaning up the resource when the name has changed
@zirain the issue here when the name changes, https://github.com/envoyproxy/gateway/blob/82ce107e76bfc9b8d7f1e2704c7d294bbb8b9606/internal/infrastructure/kubernetes/proxy/resource_provider.go#L322 we need to also delete the previously named resource, but this is called during the IR create/update flow