Arka Pratim Chaudhuri comments

Results 13 comments of


                                            Arka Pratim Chaudhuri

Bug: [flat config] ESLint continues linting files after an error occurs

Hi, I just had a question - the `throw` which is coming from no-undef.js, that isnt failing the `Promise.all` ? https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/all#promise.all_fail-fast_behavior

Bug: `no-restricted-properties` misses destructuring object returned from function call

I’m going to do this, give me two weeks.

Enhancement: [no-floating-promises] add an 'allowForKnownSafePromises' option

Hi :wave:, I just had 2 questions. 1. Will these be the preferred reports by the rule ? I'm asking this because I'm very unfamiliar with redux The valids -...

chore(eslint-plugin): deprecate no-var-requires in favor of no-require-imports

Hi, I just have one doubt, just to make sure I understood the problem correctly In `no-require-imports` if we set `allowAsImport` as `true`, then all the test cases in `no-var-requires`...

chore(eslint-plugin): deprecate no-var-requires in favor of no-require-imports

The tests which failed in this pr, failed in the v8 branch too ? https://github.com/typescript-eslint/typescript-eslint/commit/c0bf6fc21f82f9545f01a2606f522efa43fdd06c , see the CI check in this commit.

feat(eslint-plugin): [no-floating-promises] add an 'allowForKnownSafePromises' option

Ahh... I think I made a terrible mistake. Thanks for the reviews though. I'm marking this as draft. I need some more time to thoroughly read the issues once again....

feat(eslint-plugin): [no-floating-promises] add an 'allowForKnownSafePromises' option

Yes, I've almost done the tests, give me just 3 more days. I'll open it for review.

feat(eslint-plugin): [no-floating-promises] add an 'allowForKnownSafePromises' option

Thanks for the reviews. I'm just writing down some notes for the future people who are going to stumble upon this pr. 1. `then` and `catch` functions with 1 and...

fix(eslint-plugin): [no-unnecessary-condition] ignore optionally accessing index signatures

Ye, sorry, closing this pr, didn't mean to cookie lick it. I made it draft cause there were merge conflicts.

fix: `parser.hooks.new` for classes defined in the same module

Hi @snitin315, this pr doesnt solve for [innerGraph: false](https://webpack.js.org/configuration/optimization/#optimizationinnergraph), I think thats why the tests failed in JavascriptParser.unittest.js(because the Parser doesnt have the plugin). Since, this pr was inactive for...