Arkadeep Sen
Arkadeep Sen
> This PR adds the support of capacity reservation group in `AzureMachineSpec`. `AzureMachineSpec` -> `AzureMachineProviderSpec`
> Yeah lets get those added > > Also, since we are close to the feature freeze date, I'd like to see the feature tested end to end by QE...
@npinaeva I have made the suggested changes. PTAL.
> btw #4251 got merged @npinaeva updated code accordingly
> thank you for patience and a great contribution @arkadeepsen! Thanks @npinaeva for providing your feedback and suggestions to the PR.
> Thanks @arkadeepsen! > > The `azuremachine_types.go` file is used in generating the CRDs. So you need to run `make generate` and commit those changes or this will fail the...
> I see the validation is already being done in [ValidateCapacityReservationGroupID](https://github.com/willie-yao/cluster-api-provider-azure/blob/5243ae7d5dae9483280e73da2904a3568fbf8839/api/v1beta1/azuremachine_validation.go#L463). I think the clarity helps but other fields that have similar requirements do not include this information in the...
Have already started working on this.