ovn-kubernetes icon indicating copy to clipboard operation
ovn-kubernetes copied to clipboard

Published 20 hours ago • verified publisher icon ovn-org

Add support for DNSNameResolver

Open arkadeepsen opened this issue 2 years ago • 5 comments

This PR adds the support for DNSNameResolver in ovnk as per the enhancement proposal openshift/enhancements#1335.

This feature is enabled via a new flag enable-dns-name-resolver. However, enable-egress-firewall flag should also be set for this feature to be enabled.

cluster-manager watches for events related to EgressFirewall objects and creates/deletes the DNSNameResolver objects based on the events.

ovnkube-controller watches DNSNameResolver to get the latest IP addresses associated with a DNS name. resolver is initialized instead ofegressFirewallDNS and it is used to create/destroy/update address sets related to DNS names.

If the enable-dns-name-resolver is not enabled, then the behavior of ovnk doesn't change.

arkadeepsen avatar Dec 09 '23 16:12 arkadeepsen

Coverage Status

coverage: 52.689% (+0.3%) from 52.418% when pulling 6788da1e5f5c664fc59da1156103acb0b2ab2379 on arkadeepsen:dnsnameresolver into 9bf6a484cb7a4ea486114061cd06880ff06f4432 on ovn-org:master.

coveralls avatar Dec 09 '23 16:12 coveralls

@npinaeva I have made the suggested changes. PTAL.

arkadeepsen avatar Feb 01 '24 07:02 arkadeepsen

Deploy Preview for subtle-torrone-bb0c84 ready!

Name Link
Latest commit c9a21692ed203436694402547b65a1d20d59fc5f
Latest deploy log https://app.netlify.com/sites/subtle-torrone-bb0c84/deploys/662936d36165a50009a01690
Deploy Preview https://deploy-preview-4045--subtle-torrone-bb0c84.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Mar 26 '24 18:03 netlify[bot]

btw https://github.com/ovn-org/ovn-kubernetes/pull/4251 got merged

npinaeva avatar Apr 22 '24 16:04 npinaeva

btw #4251 got merged

@npinaeva updated code accordingly

arkadeepsen avatar Apr 23 '24 05:04 arkadeepsen

thank you for patience and a great contribution @arkadeepsen!

Thanks @npinaeva for providing your feedback and suggestions to the PR.

arkadeepsen avatar May 07 '24 04:05 arkadeepsen

Can we add e2es to make sure this new feature works?

that is planned as a separate PR, as it requires some more work to add dnsresolver to the kind cluster here https://github.com/openshift/coredns-ocp-dnsnameresolver. The feature will need only the operator provided by ^ to work. In openshift it is deployed as a part of cluster-dns-operator, but we need some more time to make it work with kind.

npinaeva avatar May 08 '24 07:05 npinaeva