Arjan Tijms
Arjan Tijms
> @arjantijms why not using a valve as most integrators? You can't add a valve from your war, so that puts additional constraints on the user. For a simple integration...
I'll investigate the application specific Valve. Can META-INF/context.xml exist on the class path as well, or does it have to be inside [war root]/META-INF? > Use reflection as several other...
> I share the concern that adding a getRequest() method may undermine the use of a facade. Isn't the facade intended as a service to the user to not accidentally...
> being said the getRequest() does not really work in all cases in your example In what cases doesn't it work? > Guess a sane EE way to solve that...
@rmannibucau oh yeah, of course, then it won't work. It'll throw an exception, so at least you know it won't work ;) `requestInitialized()` is really early though, so in most...
> It's hard to see how this concept can ever be a good idea. I personally think it's a brilliant idea. Then again, I'm probably biased ;)
> I would be against exposing container internals via the Servlet API as it undermines portability. Well, actually it could be used by integration libraries to improve portability, the exact...
Yet another example, Weld is using similar tricks to integrate with Tomcat: https://github.com/weld/core/blob/master/environments/servlet/core/src/main/java/org/jboss/weld/environment/tomcat/WeldForwardingInstanceManager.java#L97 ```java // Hack into Tomcat to replace the InstanceManager using // reflection to access private fields ApplicationContext...
Thanks for the report. It should of course work on WildFly 14. Whenever I've got some time I'll take a look.
Thx for the rapport. See https://javadoc.io/doc/jakarta.servlet/jakarta.servlet-api/latest/index.html The Pattern should be empty in both cases. We should add this same test to the TCK I guess. Payara is not compatible at...