arimus

Results 60 comments of arimus

Btw, I am able to build unmodified using Node 12.x, but 14.x and 16.x result in the error above. But yes @johnpoth there is basically nothing in there to replace...

FWIW, I ran into this with Sharp on OSX as well. Hadn't had any problems and then I couldn't stop the issue. Upgraded from 7.6.0 -> 7.9.0, did a `pnpm...

@glasser I could potentially help on the hapijs integration when things are ready

@trevor-scheer great, I'll take a look!

Just an FYI that I'm looking to begin working on this soon. I've been unable to tackle it as of yet, but just wanted to keep folks in the loop....

Note: I did also create a v2 backport of this improvement if anyone wants me to take the time to create another pull request. And sorry for the noise, had...

> @arimus: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ I actually did already. There...

> Thanks, I'll try to make time to review this when I have time to refresh my memory of how Hapi works. > > I'm not super clear on how...

@glasser I've checked in some new changes which should fully fix the aforementioned ticket, with some better tests to verify them to boot. I did have to re-factor the createServer()...

Understood and makes sense. I'll address the issues you noted soon. Thanks for the review...not sure how I missed a couple of those. On Thu, Jan 20, 2022, 9:56 PM...