argo-ui

argo-ui copied to clipboard

refactor(deps): remove `moment` dep and usage

6

Related to the goals of https://github.com/argoproj/argo-workflows/issues/12059, just removing / replacing a large dep entirely. Follow-up to https://github.com/argoproj/argo-workflows/pull/12097 and #534 here. Needed for https://github.com/argoproj/argo-workflows/pull/12611 ### Motivation `moment` has been [deprecated since...

agilgur5

feat: #17436 Update dropdown-menu.tsx to have standard link behaviour

2

Closes [ISSUE #17436] 

Hussain-Ruhullah

## Motivation - This PR adds a tag `role="checkbox"` to the navItems. This has the benefit that keyboard users can use vimium to navigate the user interface. At the moment,...

michaelfresco

fix(lint): replace non-existent `qe-id` with `data-qe-id`

4

### Motivation - `lint` was erroring out: `Unknown property 'qe-id' found react/no-unknown-property` ~I'm not sure why it didn't pop up during #509 though... It's also only popping up on certain...

agilgur5

Necessary for https://github.com/argoproj/argo-cd/pull/18116

agaudreault

refactor(ci): standardize Stale Action config

1

### Motivation - fix OpenSSF Scorecard issues - have consistent settings here as in Workflows ### Modifications - fix OpenSSF Scorecard issues - set top-level `permissions` to read-only - add...

agilgur5

chore(deps): remove unused `antd` directory and deps

1

Per https://github.com/argoproj/argo-ui/issues/553#issuecomment-2106048778 and https://github.com/argoproj/argo-ui/issues/453#issuecomment-2106051851, remove the unused `antd` dir and deps - `antd` was seemingly meant to be used in `v2` per https://github.com/argoproj/argo-ui/pull/161#pullrequestreview-820560829, but that never happened. - It's been...

agilgur5

chore(deps): dedupe `yarn.lock`, add check for dupes

5

Equivalent to https://github.com/argoproj/argo-workflows/pull/11637 and PRs I've made in other repos ### Motivation Same as downstream et al, see https://github.com/atlassian/yarn-deduplicate#why-is-this-necessary Removes ~2.5k+ LoC from the `yarn.lock` by consolidating duplicated deps (and...

agilgur5

Follow-up to https://github.com/argoproj/argo-ui/pull/535#issuecomment-2151143975, fixes the issue I discovered in https://github.com/argoproj/argo-cd/pull/19655#issuecomment-2305897525 ### Motivation I previously left in `durationMs` for backward-compatibility so that you could use either, but I forgot to mark...

agilgur5

Ref: https://github.com/argoproj/argo-cd/pull/19620 Screenshot:

ashutosh16