arckoor
arckoor
Yea, with clang it does work without issue. As far as I know we currently do not need the feature at all, I just happened to notice while testing for...
I'm not sure why we didn't do it this way in the first place, sorry about that. I think doing it this way is way nicer for the user, because...
@randombit I'm currently redoing all the tests, and I can test the encode by comparing the expected bits to `cert.v3_extensions().get_extension_bits(IPAddressBlocks::static_oid())`. Can I somehow do something similar for decoding? I'd like...
The API I'm mostly happy with now, though I'm still debating whether there should be helper methods for things like "inherited", or if the user should interpret the `std::nullopt` themselves....
:thinking: `clang-tidy` doesn't seem to check the `x509_ext.h` file. I also tried running it locally, same thing, but maybe I'm also just doing it wrong / missing something
@randombit can I please get a review of this? The next release is drawing closer, and we need to either merge this or revert #4699. We cannot leave it as...
@randombit fair points, I'll add the old constructors back in, but I'd really like to keep even the mutable methods like `restrict_*`, without them FFI would be very painful. In...
@randombit should be ready to take a look again. The only changed test I kept as it was is the decode test, since I find straight values more easily readable...
@randombit @reneme could you take a look and tell me what you think? Still WIP, almost no tests, but the python binding is usable-ish
The normal copilot comments I already mentioned myself, funnily enough the low-confidence suppressed ones are valid issues :thinking: