Blaž Hrastnik

I don't quite understand the issue, we track the initial `trigger_offset` when `completion` is triggered: https://github.com/helix-editor/helix/blob/7eb013c6fb33df40b2fae31c9d08f7da275cd963/helix-term/src/commands.rs#L3490 Then we use that trigger offset when needed: https://github.com/helix-editor/helix/blob/7eb013c6fb33df40b2fae31c9d08f7da275cd963/helix-term/src/ui/completion.rs#L111-L117 We also remove any extra...

We might need to call `.savepoint` sooner, inside `fn completion` rather than here https://github.com/helix-editor/helix/blob/0062af6a19d96e0a4c3f94e3e44c179230e005b9/helix-term/src/ui/completion.rs#L152-L153

Hey @cossonleo I want to finally get this merged but I'm trying to understand the fix. Does it immediately set a save point, then when completion data arrives it filters...

Sorry, I'll look at this PR this week!

Looks like my comments didn't get posted last time: I think moving `doc.savepoint()` before the callback is the only change needed to fix the completion. Why is savepoint now storing...

Hope #3379 fixes the issue, let me know if we need to reopen! Thanks to @AceofSpades5757 for the quick fix 🎉

Just set the scrolloff config value to something really high (999).

Surprisingly little code to get this working 👍🏻

You could cheat and ignore any scopes that `start_with("ui.")`

You could get fancy and calculate the color contrast and only pick colors that are distant enough :D