helix icon indicating copy to clipboard operation
helix copied to clipboard

Running a shell command breaks terminal sequences

Open CptPotato opened this issue 1 year ago • 2 comments

Summary

After running a shell command some inputs don't work anymore.

I ran into these two:

  • mouse input has no effect
  • CtrlC sends a keyboard interrupt and kills helix, instead of toggling a comment

It's worth noting that :pipe does not cause this broken behavior.

Reproduction Steps

  • run helix
  • :sh echo hi
  • try using the mouse or toggling a comment (CtrlC)

Helix log

nothing of interest

Platform

Windows 10 x64

Terminal Emulator

wezterm (nightly)

Helix Version

helix 22.05 (3e11017a)

CptPotato avatar Aug 09 '22 14:08 CptPotato

It looks like this may be the culprit. But not sure why we lose some input control.

3121353c6ab2fbc5fced28f075c7fc45b53b661e

AceofSpades5757 avatar Aug 10 '22 00:08 AceofSpades5757

This may be Windows specific; I can't reproduce on linux.

the-mikedavis avatar Aug 10 '22 00:08 the-mikedavis

Hope #3379 fixes the issue, let me know if we need to reopen! Thanks to @AceofSpades5757 for the quick fix 🎉

archseer avatar Aug 12 '22 02:08 archseer

Yup, this has fixed the issue for me 👍

CptPotato avatar Aug 12 '22 07:08 CptPotato