Archit Agarwal

Results 6 comments of Archit Agarwal

I am not in favour of adding extra parameters as that becomes backwards incompatible and all clients will have to fix the use once they upgrade. I liked the 1st...

Hi @brackendawson, I can fix this doc-string for assert and require. To reconfirm we want to update the doc not to have an example that uses if block and then...

> Yes. The change in require is automatic, just run `go generate ./...`. @brackendawson, I have created pull request #1675, can you please help me with review on this.

> The change now hides that `Error` returns a boolean that can be used for further checks. > > I think that we must keep the if statement around in...

> @architagr I'd like to get this merged but I can't in good faith dismiss @dolmen's review because this PR still removes the last reference to assert's functions returning a...

> @architagr I'd like to get this merged but I can't in good faith dismiss @dolmen's review because this PR still removes the last reference to assert's functions returning a...