archimedus
archimedus
Thanks. Now I see how it has appeared in the code. Due to return from entry point has been removed from examples, I suppose there is no reason to keep...
1. OK: ACCELERATION_STRUCTURE BOTTOM_LEVEL and ACCELERATION_STRUCTURE TOP_LEVEL 2. I would use exact Vulkan spec name (i.e. bindING): SHADER_BINDING_TABLE 3. agree 4. "BLAS_INSTANCE USE. Could this just be BOTTOM_LEVEL {name}" This...
Syntax updated https://github.com/google/amber/commit/d4a407943094bff32cc498addbfae394bfbf5ad6 Also link to example CTS implementation added into head.
> the type of a thing from the name. Yes I was incorrect, I meant that it is deduced from shader types included into group, not shader group name. I...
I think we have enough for initial RT support, thus I created PR for this issue https://github.com/google/amber/pull/1035
I think we can go with part 2 within this issue that is in https://github.com/google/amber/pull/1039 Edit: We have https://github.com/google/amber/issues/1038 for it, thus closing this one.
> Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll...
> I don't believe you need a google account. In order to accept the contribution you'll need to go to https://cla.developers.google.com/ and sign the CLA. Thank you for quick reply....
kokoro:run
kokoro:run