Alex Arslan

Results 501 comments of Alex Arslan

Why can't you just use DataFrames?

That used to be the case a long time ago, but DataFrames can now hold arbitrary columns. So it could be `Vector{DataValue}` or whatever.

Ideally `describe` would be removed from one or both packages, as it's more of a statistical function than a tabular data function. Maybe that could live in StatsModels at some...

Yes, but unless we want a dependency on AbstractTables in StatsBase (which I don't think we should do), we'd still have to define the generic `describe` method on tables elsewhere....

Ohhhhhhhhhhhhhhhhhhhhhhhh heh, DataFrames and DataTables both `@reexport` StatsBase. I bet that's it.

Assuming they don't contain code specific to `Nullable`s and/or `NA`, yes, those methods should live in StatsBase. Good catch!

I think this is the primary case you'd need to watch out for: https://edfplus.info/specs/edfplus.html#timekeeping. Otherwise what you described is how I'd do it. Shameless company promotion but you may be...

Alternative, backwards-compatible-ish possibility: ```diff --- a/src/types.jl +++ b/src/types.jl @@ -48,20 +48,26 @@ struct SignalHeader end """ - EDF.Signal{T} + EDF.Signal{T,V} -Type representing a single EDF signal with sample type `T`....

xref https://github.com/beacon-biosignals/EDF.jl/issues/31 Tangentially relevant but EDF+ has a [specification](https://edfplus.info/specs/edffloat.html) for how to handle values that are too large to be represented in 2 bytes. (Spoiler alert: you just take a...