Kshitij Aranke
Kshitij Aranke
Another approach I considered for a similar project was creating a boolean column to indicate whether the table had coverage. Could probably use `true`/`false` for JSON and `✅`/`❌` for the...
@MichelleArk Any idea why `tests/unit/test_plugin_manager.py::TestPluginManager::test_get_nodes` is failing across all Python versions here?
> Do we also need to update [`main`/core/setup.py#L88-L97](https://github.com/dbt-labs/dbt-core/blob/main/core/setup.py?rgh-link-date=2024-02-26T16%3A20%3A44Z#L88-L97)? Done, thanks!
> I noticed that part of the acceptance criteria was to ensure that bundles can be created with Python 3.12. Should we confirm that **before** merging this? How would you...
Potential fix: > It looks like sources are not included in the search strategy for the FQN selector: https://github.com/dbt-labs/dbt-core/blob/9d232398eed32caf07487b0df790bfd5f792e0c2/core/dbt/graph/selector_methods.py#L255-L263 I can change this to all_nodes which should include sources.
@emmyoop It looks like `pip` already retries network connections up to 5 times: https://pip.pypa.io/en/stable/cli/pip/#cmdoption-retries Given this information, I'm not sure if adding retries to our test runner (tox in this...
Code: TK Python built-in modules: https://docs.python.org/3/library/sys.html#sys.builtin_module_names
Hey @l1xnan, Thanks for the PR, it looks good to me! Can you please sign the CLA and add a changelog entry so we can merge this in? Instructions on...
@jtcohen6 @graciegoheen I tried the proposed fix locally and observed the following behaviors: 1. ✅ The error is surfaced in the CLI 2. ❓ The hook result isn't written to...
It looks like `on-run-start` errors for `dbt run` aren't written to `run_results.json`, so I'll maintain this behavior for `dbt source freshness` for now. Do we want to keep this behavior,...